Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: login WIP #7779

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Dec 12, 2023

Closes #7765

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@marc2332 marc2332 marked this pull request as ready for review December 19, 2023 08:54
@marc2332 marc2332 merged commit a758ef1 into feat/single-account-wallet-creation Dec 19, 2023
0 of 4 checks passed
@marc2332 marc2332 deleted the refactor/login branch December 19, 2023 08:58
begonaalvarezd added a commit that referenced this pull request Dec 20, 2023
* feat: Single account wallet creation, WIP

* typo

* refactor(wip): create api core module

* refactor(wip): refactor profile core module

* refactor(wip): refactor profile core module

* refactor(wip): refactor profilemanager core module

* refactor(wip): refactor profilemanager core module

* merge account into wallet

* move utils from profile manager to profile

* rename every createAccount to createWallet

* remove old mocks and tests

* rename account stuff to wallet

* rename account errors to wallet errors

* clean up `deleteWallet`

* fix imports

* fix more imports

* 🙂

* import fixes and logic improvements..

* fix links

* :hurtrealbad:

* :godmode:

* refactor: Onboarding (#7763)

* refactor: Onboarding WIP

* fix: improve logs and try to sync balances for wallet WIP

* refactor: complete onboarding

---------

Co-authored-by: cpl121 <[email protected]>

* refactor: login WIP

* fix: selected wallet id

* mmm, some improvements and fixes

* fixes and improvements

* fixes and clean up

* refactor: Fix Login and onboarding improvements  (#7779)

* refactor: login WIP

* fix: selected wallet id

* mmm, some improvements and fixes

* fixes and improvements

* fixes and clean up

---------

Co-authored-by: marc2332 <[email protected]>

* refactor(2.0): Fix the Dashboard component

* refactor(2.0): Hide Wallet switcher

* format

* lint

* format

* lint

* fix as many as possible tests

* revert non-english translations changes

* mm

* revert other non-english translations changes

---------

Co-authored-by: Begoña Alvarez <[email protected]>
Co-authored-by: cpl121 <[email protected]>
Co-authored-by: cpl121 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants